49 feature request flatmap #57
Conversation
observable/observable.go
Outdated
| @@ -69,7 +70,8 @@ func (o Observable) Subscribe(handler rx.EventHandler) <-chan subscription.Subsc | |||
| } | |||
|
|
|||
| // OnDone only gets executed if there's no error. | |||
| if sub.Error == nil { | |||
| nilPassed := !reflect.ValueOf(sub.Error).IsValid() | |||
There was a problem hiding this comment.
Why this change? Write test to justify the problem or improvement
There was a problem hiding this comment.
I’ll add the test for it. Forgot to implement it.
There was a problem hiding this comment.
Not problem, code review is for that
venth
force-pushed
the
49_feature-request-flatmap
branch
from
3d93883
to
655cc70
Compare
|
Thank you :) You were right. I have idea for other operators as well like: create, merge, zip. Shall I add issue before hand? |
|
@avelino is this going to me merged in? |
@marcsantiago @venth this week I will analyze, apparently we need an use example in the README (In the future on wiki), I keep you informed if I have some other point. |
There was a problem hiding this comment.
write example used on
https://github.com/ReactiveX/RxGo/tree/master/examples
and README pls
|
@avelino, I'll provide examples and complete the README documentation over the weekend. Thanks for reviewing the code 👍 |
|
Sorry to make review broken, I am with limited time |
venth
force-pushed
the
49_feature-request-flatmap
branch
from
655cc70
to
f4a32c6
Compare
|
@avelino I've pushed the changes. Would you like to take a look at them? |
Pull Request Test Coverage Report for Build 130
💛 - Coveralls |
|
thanks @venth |
|
@avelino I’ve just pushed improvements to test coverage and fix one error. How can I fix it? Next PR? |
|
Open new PR @venth |
I've prepared flatMap operator, which is consistent with current implementation. Feature request issue: #49 Feature Request: FlatMap