Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are we missing skipLast operator? #1404

Closed
staltz opened this issue Mar 1, 2016 · 4 comments
Closed

Are we missing skipLast operator? #1404

staltz opened this issue Mar 1, 2016 · 4 comments
Labels
feature PRs and issues for features

Comments

@staltz
Copy link
Member

staltz commented Mar 1, 2016

We currently don't have skipLast implemented. Are we removing it intentionally or just forgot to build it?

Notice the discrepancy here:

  • skip
  • skipUntil
  • skipWhile
  • take
  • takeLast
  • takeUntil
  • takeWhile
@benlesh
Copy link
Member

benlesh commented Mar 1, 2016

Maybe. The use-cases for skipLast are slim. But it seems like a missing operator. I'd say it's probably not a core operator though.

@staltz
Copy link
Member Author

staltz commented Mar 1, 2016

I'd add it just for symmetry. It's not something I'm really pushing for. Just stumbled upon this when writing docs.

@benlesh benlesh added feature PRs and issues for features priority: low labels Mar 21, 2016
@bardiarastin
Copy link

i have an issue because of that this is no longer available in Rx5
http://stackoverflow.com/q/41650365/7091035

martinsik added a commit to martinsik/rxjs that referenced this issue Jan 30, 2017
@martinsik
feat(skipLast): adds skipLast operator
47f5752 
Adds skipLast operator from RxJS 4. Its internals and tests are based on takeLast for better

performance.

Closes ReactiveX#1404
@martinsik martinsik mentioned this issue Jan 30, 2017
Merged
7 tasks
benlesh pushed a commit that referenced this issue May 9, 2017
@martinsik @benlesh
feat(skipLast): add skipLast operator (#2316)
4ffbbe5 
* feat(skipLast): adds skipLast operator

Adds skipLast operator from RxJS 4. Its internals and tests are based on takeLast for better

performance.

Closes #1404

* docs(skipLast): updated decision tree, MIGRATION.md and operators.md

* docs(skipLast): fix tree.yml as suggested by @staltz

* refactor(skipLast): refactored skipLast operator
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature PRs and issues for features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@staltz @benlesh @bardiarastin