Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol shim is created as an object but should be a function #988

Closed
wkwiatek opened this issue Dec 8, 2015 · 2 comments
Closed

Symbol shim is created as an object but should be a function #988

wkwiatek opened this issue Dec 8, 2015 · 2 comments
Assignees
Labels
bug Confirmed bug

Comments

@wkwiatek
Copy link

wkwiatek commented Dec 8, 2015

Hey,

I had an issue with zone.js regarding checking whether Symbol exists in the browser or not and it turned out that RxJS is initializing Symbol as an object (the real implementation resolves it as a function). This incompatibility may affect other libraries which relies on symbols (what happens with zone.js).

In the library code it's probably following line responsible for that: https://github.com/ReactiveX/RxJS/blob/master/src/util/SymbolShim.ts#L12

Here is a plunker to see the problem:
http://plnkr.co/edit/hpvSjZDERVJHiLrgLd23

And the output from browser which doesn't support symbols is as follows (Win 7 / IE 11 - BrowserStack):
bs_win7_ie_11 0 1

@benlesh
Copy link
Member

benlesh commented Dec 8, 2015

This is related to #999 for sure. It needs to be a function:\ I did that.

@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Confirmed bug
Projects
None yet
Development

No branches or pull requests

2 participants