refactor(WebSocketSubject): make 'WebSocketSubject._unsubscribe' protected #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixed the conflict |
|
I'm seeing couple of commits (i.e, tetsuharuohzeki@73cf3cd) are under same category of this refactoring. What about creating single commit-PR to amends this changes at once? it'll give easier history lookup (in my opinion). |
|
May I mix their change into single pull request? I felt these have difference context (tetsuharuohzeki@73cf3cd is a part of cleanup for ConnectableObservable and this is a part of WebSocketSubject) |
|
I think so, if PR contains single scope of changes. Feel freely close PR as needed. |
|
okay, I cherry-pick this patch on #1244 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.