-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(CONTRIBUTING): Updated the test section to include Travis and saucelabs #1271
Conversation
@@ -121,6 +121,9 @@ then it must cover the following cases: | |||
- Success with the context, if any allowed in the operator signature | |||
- If an error is thrown | |||
|
|||
#### <a id="unit-tests"></a>CI Tests | |||
- Set your [Travis](https://travis-ci.org/) account to point against your fork |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about adding some more background explanation for these tests? below's few topics I can think of :
travis
setup on forked repo will allow ci tests on forked repo without submitting PR to mastersaucalabs
setup will allow run browser test on forked repo: due to saucelab doesn't allow browser test on PR, this will help verify test results before PR's checked in master- since master runs both of test per each check in, it'd be welcome to setup those test for creating PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great to me: updated PR now
Thanks for update! would you mind one small favor to flatten commit into single one? I think these change can be single commit, like
I can handle those so feel freely ping me if you have difficulties with it, but would like to let you have full control over your contribution :) |
… Travis and saucelabs
Thanks @kwonoj, how does this look? (squash merged) |
Thanks for update, yes, change looks good to me. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
In reference to @staltz comment on #1257 to adding saucelabs information to the Travis configuration.
Btw, this is my first pull request to Rx: hoping I followed the right procedure here.