Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(typings): update type definition references #1332

Closed
wants to merge 1 commit into from
Closed

chore(typings): update type definition references #1332

wants to merge 1 commit into from

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Feb 11, 2016

This PR introduces small organization changes to referencing external type definitions.

  • Delete type definitions included in codebase not referenced
  • Referenced type definition(es6-shim) is managed by type definition manager(https://github.com/typings/typings). npm install will resolves type definition also.
  • Still refers to ambient es6-shim as is for now, instead of referring external type definitions.

@kwonoj
Copy link
Member Author

kwonoj commented Feb 11, 2016

in further, es6-shim definition can be replaced into only required external type definition set, such as es6-promise and es6-collections since those are only necessary reference in current codebase. (#1270)

@kwonoj kwonoj added the blocked label Feb 23, 2016
@kwonoj
Copy link
Member Author

kwonoj commented Feb 23, 2016

Marking this as blocked for now, #1364 better to be checked in prior to this PR (if it's accepted).

@kwonoj kwonoj removed the blocked label Mar 1, 2016
@kwonoj kwonoj force-pushed the chore-typings branch 2 times, most recently from bdbada0 to 6e718b6 Compare March 7, 2016 07:52
@kwonoj
Copy link
Member Author

kwonoj commented Mar 7, 2016

I'll check this in around today.

@kwonoj
Copy link
Member Author

kwonoj commented Mar 8, 2016

Merged with 03edd9a .

@Blesh @staltz @trxcllnt @luisgabriel @saneyuki @david-driscoll please retrigger npm install once again with master, this change requires it.

@kwonoj kwonoj closed this Mar 8, 2016
@kwonoj kwonoj deleted the chore-typings branch March 8, 2016 00:29
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kwonoj