Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(FromEventPatternObservable): remove to use tryCatch #1397

Merged
merged 1 commit into from May 24, 2016
Merged

refactor(FromEventPatternObservable): remove to use tryCatch #1397

merged 1 commit into from May 24, 2016

Conversation

tetsuharuohzeki
Copy link
Contributor

There is no perf regression.

This is the benchmark result on Node v5.6.0,
MacBook Air (13-inch, Mid 2012, 1.8 GHz Intel Core i5, 8 GB 1600 MHz DDR3).

before

                                         |                     RxJS 4.0.7 |              RxJS 5.0.0-beta.2 |          factor |      % improved
---------------------------------------------------------------------------------------------------------------------------------------------------
            fromeventpattern - immediate |               148,483 (±1.75%) |               347,956 (±2.42%) |           2.34x |          134.3%

after

                                         |                     RxJS 4.0.7 |              RxJS 5.0.0-beta.2 |          factor |      % improved
---------------------------------------------------------------------------------------------------------------------------------------------------
            fromeventpattern - immediate |               145,944 (±1.21%) |               351,992 (±2.82%) |           2.41x |          141.2%

@tetsuharuohzeki tetsuharuohzeki mentioned this pull request Mar 1, 2016
Closed
19 tasks
benlesh
benlesh reviewed Mar 9, 2016
View reviewed changes
src/observable/FromEventPatternObservable.ts
subscriber.error(result.e);
} else {
const handler = !!this.selector ? (...args: Array<any>) => {
const [ok, result] = this._callSelector(subscriber, args);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as with the other PR, I'm not sure this approach with the additional Array allocation is benefitting us.

@tetsuharuohzeki
Copy link
Contributor Author

@Blesh updated.

                                         |                     RxJS 4.1.0 |              RxJS 5.0.0-beta.2 |          factor |      % improved
---------------------------------------------------------------------------------------------------------------------------------------------------
            fromeventpattern - immediate |               393,732 (±2.93%) |               933,987 (±1.49%) |           2.37x |          137.2%

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.982% when pulling f99895b on saneyuki:fromEventPattern into d9855e2 on ReactiveX:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.982% when pulling f99895b on saneyuki:fromEventPattern into d9855e2 on ReactiveX:master.

@benlesh benlesh merged commit 3dc1c00 into ReactiveX:master May 24, 2016
@tetsuharuohzeki tetsuharuohzeki deleted the fromEventPattern branch May 31, 2016 04:44
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tetsuharuohzeki @coveralls @benlesh