Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(forEach): add the benchmark #1402

Closed
wants to merge 1 commit into from
Closed

chore(forEach): add the benchmark #1402

wants to merge 1 commit into from

Conversation

tetsuharuohzeki
Copy link
Contributor

No description provided.

@tetsuharuohzeki
Copy link
Contributor Author

By #1434, using tryCatch was removed. This pull request changes to add the benchmark

@tetsuharuohzeki tetsuharuohzeki changed the title refactor(forEach): remove tryCatch chore(forEach): add the benchmark Mar 18, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.982% when pulling 925de16 on saneyuki:observable into d9855e2 on ReactiveX:master.

@benlesh
Copy link
Member

benlesh commented Mar 18, 2016

This isn't ever going to be an "apples-to-apples" perf test between RxJS 4 and RxJS 5, since they do two different things. I think the RxJS 4 test should just show "N/A" or something.

@benlesh
Copy link
Member

benlesh commented Mar 29, 2016

@saneyuki... for the "Old" Rx4 test, do you think you can figure out something to have it just show as "N/A". This comparison isn't really applicable, but I'd like to capture the metrics. Perhaps we need to add a new type of perf tests to our micro perf suite that is for Rx5-only functionality?

@benlesh
Copy link
Member

benlesh commented May 24, 2016

This seems to have gone stale, @saneyuki so I'm going to close it for now.

@benlesh benlesh closed this May 24, 2016
@tetsuharuohzeki
Copy link
Contributor Author

@Blesh: This seems to have gone stale, @saneyuki so I'm going to close it for now.

Ah, okay. I'm sorry to my reply was too late.

@tetsuharuohzeki tetsuharuohzeki deleted the observable branch May 31, 2016 08:16
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants