Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deferObservable): accepts factory returns promise #1484

Closed
wants to merge 1 commit into from

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Mar 18, 2016

Description:

I came to notice PR #1479 becomes redundant by issue #1483 filed after, allowing promise returned by factory function. I have closed #1479 and create this one instead to reflect those.

  • factory function now can return either Observable or Promise
  • deferObservable internally utilizes subscribeToResult
  • as suggested in test(deferObservable): add type definition test #1479, no longer include duplicated type definition test but test case reflects definition usecases

Related issue (if exists):

relates to #1483

** Notes **

Not sure if this change's intended direction in #1483. /cc @trxcllnt to ask review if this change makes sense.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 95.987% when pulling bfe58a1 on kwonoj:type-defer into 91d019c on ReactiveX:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 95.987% when pulling cf53d29 on kwonoj:type-defer into 91d019c on ReactiveX:master.

@kwonoj
Copy link
Member Author

kwonoj commented Mar 21, 2016

Merged with 0cb44e1 .

@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants