Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxScala #1340

Closed
headinthebox opened this issue Jun 9, 2014 · 6 comments
Closed

RxScala #1340

headinthebox opened this issue Jun 9, 2014 · 6 comments
Milestone

Comments

@headinthebox
Copy link
Contributor

I thought we agreed to keep create to avoid confusion (i.e. for those that watch the Coursera course) and all. So let's remove the annotation.

@deprecated("Use `apply[T](Subscriber[T] => Unit)` instead", "0.17.0")
@headinthebox headinthebox added this to the 0.20 milestone Jun 9, 2014
@zsxwing
Copy link
Member

zsxwing commented Jun 9, 2014

Looks RxJava will remove create(final OnSubscribeFunc<T> f) in 1.0. So implement it in RxScala?

@headinthebox
Copy link
Contributor Author

Yes, let's do that. Let's leverage the fact that Scala has apply so we can use create for unconfusing the students.

@samuelgruetter
Copy link
Contributor

+1

@samuelgruetter
Copy link
Contributor

It's now two years, later, and things might have changed since then, so maybe we should revisit this decision? That is, I suggest to deprecate and then remove the method

def create[T](f: Observer[T] => Subscription): Observable[T]

Is this cousera course still being taught?
I'm suggesting this because it seems that nowadays, people are not confused by the absence of this method, but by its presence, see this issue.

@akarnokd
Copy link
Member

Wrong project? RxJava no longer has such a create() factory method but one that takes OnSubscribe<T>:

https://github.com/ReactiveX/RxJava/blob/1.x/src/main/java/rx/Observable.java#L93

although the SyncOnSubscribe and AsyncOnSubscribe overloads may pose some problems.

@samuelgruetter
Copy link
Contributor

Oh, sorry, of course I meant RxScala. I just wrote it here because it belongs to this thread, and this thread was started when RxScala was in the same repo as RxJava.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants