Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OperatorGroupBy - redundant onStart implementation #3067

Closed
davidmoten opened this issue Jul 7, 2015 · 3 comments
Closed

OperatorGroupBy - redundant onStart implementation #3067

davidmoten opened this issue Jul 7, 2015 · 3 comments
Labels
Bug

Comments

@davidmoten
Copy link
Collaborator

These lines

https://github.com/ReactiveX/RxJava/blob/1.x/src/main/java/rx/internal/operators/OperatorGroupBy.java#L262-L264

are redundant. I'm concerned that there is some intent behind placing these lines here that is not honoured. @akarnokd looks like you put these lines here, what do you think?

The same goes for OperatorDoOnUnbsubscribe.
@akarnokd akarnokd added the Bug label Jul 17, 2015
@akarnokd
Copy link
Member

Yes, that start is unnecessary.

@KevinTCoughlin KevinTCoughlin mentioned this issue Sep 12, 2015
Merged
@KevinTCoughlin
Copy link

Related PR #3342.

@akarnokd
Copy link
Member

akarnokd commented Nov 9, 2015

Fix merged via #3342 and delivered in 1.0.15.

@akarnokd akarnokd closed this as completed Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davidmoten @KevinTCoughlin @akarnokd