Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Switch the last SerialResource to manual resource management. #4112

Merged
merged 1 commit into from Jun 25, 2016
Merged

2.x: Switch the last SerialResource to manual resource management. #4112

merged 1 commit into from Jun 25, 2016

Conversation

JakeWharton
Copy link
Member

No description provided.

@JakeWharton JakeWharton changed the title Switch the last SerialResource to manual resource management. 2.x: Switch the last SerialResource to manual resource management. Jun 24, 2016
@JakeWharton
Copy link
Member Author

Test failure is flake #4054.

@JakeWharton JakeWharton reopened this Jun 25, 2016
@JakeWharton
Copy link
Member Author

New one? Doesn't fail locally.

io.reactivex.internal.operators.flowable.FlowableReplayTest > testAsyncComeAndGo FAILED
    java.lang.AssertionError: Error(s) present: [io.reactivex.exceptions.MissingBackpressureException: Can't deliver value 184 due to lack of requests]
        at io.reactivex.subscribers.TestSubscriber.fail(TestSubscriber.java:355)
        at io.reactivex.subscribers.TestSubscriber.assertNoErrors(TestSubscriber.java:418)
        at io.reactivex.internal.operators.flowable.FlowableReplayTest.testAsyncComeAndGo(FlowableReplayTest.java:1022)
        Caused by:
        io.reactivex.exceptions.CompositeException
            at io.reactivex.subscribers.TestSubscriber.fail(TestSubscriber.java:356)
            ... 2 more
            Caused by:
            io.reactivex.exceptions.CompositeException$CompositeExceptionCausalChain: Chain of Causes for CompositeException In Order Received =>
                Caused by:
                io.reactivex.exceptions.MissingBackpressureException: Can't deliver value 184 due to lack of requests

@JakeWharton JakeWharton reopened this Jun 25, 2016
@codecov-io
Copy link

Current coverage is 70.04%

Merging #4112 into 2.x will increase coverage by 0.07%

@@                2.x      #4112   diff @@
==========================================
  Files           380        379     -1   
  Lines         27005      26990    -15   
  Methods           0          0          
  Messages          0          0          
  Branches       4345       4343     -2   
==========================================
+ Hits          18894      18904    +10   
+ Misses         6203       6192    -11   
+ Partials       1908       1894    -14   

Powered by Codecov. Last updated by e5b0b06...5faf608

@JakeWharton
Copy link
Member Author

Third time's the charm!

On Fri, Jun 24, 2016 at 11:37 PM Codecov notifications@github.com wrote:

Current coverage https://codecov.io/gh/ReactiveX/RxJava/pull/4112?src=pr
is 70.04%

Merging #4112 https://codecov.io/gh/ReactiveX/RxJava/pull/4112?src=pr
into 2.x https://codecov.io/gh/ReactiveX/RxJava/branch/2.x?src=pr will
increase coverage by 0.07%

@@ 2.x #4112 diff @@

Files 380 379 -1
Lines 27005 26990 -15
Methods 0 0
Messages 0 0
Branches 4345 4343 -2
==========================================+ Hits 18894 18904 +10 + Misses 6203 6192 -11 + Partials 1908 1894 -14

Powered by Codecov https://codecov.io?src=pr. Last updated by
e5b0b06...5faf608
https://codecov.io/gh/ReactiveX/RxJava/compare/e5b0b06646e32cd57994130ab1587ee5f0844f72...5faf6089050fe86b21440298fbc4275314b3a75b


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#4112 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAEEEVw86KVUqhMbFXEWeOn9ZrEj6e1Fks5qPKKHgaJpZM4I-NQ0
.

@akarnokd akarnokd merged commit 0405c9b into ReactiveX:2.x Jun 25, 2016
@akarnokd akarnokd added this to the 2.0 RC 1 milestone Jun 27, 2016
@JakeWharton JakeWharton deleted the jw/last-serial-resource branch August 20, 2016 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants