Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxKotlin 3 package name #227

Closed
mickverm opened this issue Feb 15, 2020 · 7 comments
Closed

RxKotlin 3 package name #227

mickverm opened this issue Feb 15, 2020 · 7 comments

Comments

@mickverm
Copy link
Contributor

RxAndroid 3 changed its package name to io.reactivex.rxjava3.android

Should RxKotlin follow the same naming strategy: io.reactivex.rxjava3.kotlin?

@vpriscan
Copy link
Collaborator

vpriscan commented Mar 11, 2020

It is already changed from io.reactivex.rxkotlin to io.reactivex.rxkotlin3, and my opinion is that changing it again would cause confusion among users (even though it is a RC).

@lwasyl
Copy link

lwasyl commented Mar 12, 2020

I'd argue for changing the package again, to io.reactivex.rxjava3.kotlin, before the final release. For one consistency will help with clarity in the long term, and changing this before the release will only be confusing/an issue for people who updated to an RC version early. But also io.reactivex.rxkotlin3 suggests compatibility with Kotlin 1.3 and not RxJava3. Perhaps with Kotlin 1.4 release there'll be need to have a separate artifact for it, in which case io.reactivex.rxjava3.kotlin4 would be available. Not sure how likely this scenario is, but anyway consistency with other rxjava3 groups feels enough to warrant the change

@vpriscan
Copy link
Collaborator

vpriscan commented Mar 12, 2020

@lwasyl I don't think package rxkotlin3 suggests Kotlin 1.3. It's not "Kotlin 3".

But consistency with other RxJava3 namings does provide warranty.

@thomasnield can you decide?

@mickverm
Copy link
Contributor Author

I'd change just for the consistency, it makes RxJava3 feel like a complete ecosystem.

@lwasyl
Copy link

lwasyl commented Mar 12, 2020

I don't think package rxkotlin3 suggests Kotlin 1.3. It's not "Kotlin 3".

That was a stretch, I admit :) I just see how version number near kotlin instead of rxjava might be confusing

@vpriscan
Copy link
Collaborator

vpriscan commented Mar 12, 2020

You have convinced me that package io.reactivex.rxjava3.kotlin is better. Reason is, yes, RxKotlin is just a tiny extension over RxJava, just like RxAndroid is. Having the mentioned package names contributes to the overall feeling that all RxJava ecosystem components are designed to work together hand in hand.
This does look nice:

import io.reactivex.rxjava3.flowables...
import io.reactivex.rxjava3.observables...
import io.reactivex.rxjava3.android...
import io.reactivex.rxjava3.kotlin...

If RxKotlin is ever rewritten in pure Kotlin, be it for JVM, JS, Native or all of them, then io.reactivex.rxkotlin<version> would make perfect sense.

@vpriscan
Copy link
Collaborator

RxKotlin 3.0.0 is released with package changed to io.reactivex.rxjava3.kotlin. We apologize to RxKotlin 3.0.0-RC1 users for inconvenience caused by the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants