Add subscriptions directly to a CompositeSubscription #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is inspired by RxSwift DisposeBag.
The idea is that you can add your
Subscription
directly (inline) to aCompositeSubscription
rather than having it assigned to a separateval
first and then manually adding it aCompositeSubscription
after assignment.Usage:
I chose the name
addTo()
so that other containers could be targeted in the future.addTo()
returns the originalSubscription
so that it could be called consecutively.A practical usage would be the Android
Fragment
instances:They have several important life cycle events such as "UI destroyed" and "Fragment destroyed".
Subscription
instances can be tied to these life cycle events throughCompositeSubscription
instances that are unsubscribed when the life cycle event happens.I've created an example and added tests for this feature.