You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here's a use case: When I add the disableAutoReleaseBuffers option to my server and i entrer a case where i don't consume the incoming content (e.g. 404 NOT FOUND) then the ByteBuf isn't released and thus creates a leak.
I would think that .ignoreContent would do the work but it seems it doesn't: you have to read the incoming ByteBuf and release it manually. This can be somewhat problematic cause using that option, rather than doing a retain where you want to use the ByteBuf, you need to do a release everywhere you do not want to use it.
And here's a couple questions while i'm at it:
Does ignoreContenthave to be called every time you do not use it ?
Does the observable you return in the RequestHandlerhave to return an Observable issued by one of the response methods or would any observable do (even Observable.empty) ?
Thanks
The text was updated successfully, but these errors were encountered:
@Crystark Apologies for the delayed response. This sounds like a bug. One should not be forced to call .ignoreContent(). In absence of a subscriber, the buffer must be released with disableAutoReleaseBuffers.
…not subscribed)
When auto-release it turned off and the HTTP content is not subscribed, the buffers which are disposed from `UnicastContentSubject` are not released (which otherwise would have been released by the subscriber).
This change properly release the disposed buffers when auto-release is turned off.
…ribed) (#497)
When auto-release it turned off and the HTTP content is not subscribed, the buffers which are disposed from `UnicastContentSubject` are not released (which otherwise would have been released by the subscriber).
This change properly release the disposed buffers when auto-release is turned off.
Hi,
Here's a use case: When I add the
disableAutoReleaseBuffers
option to my server and i entrer a case where i don't consume the incoming content (e.g. 404 NOT FOUND) then theByteBuf
isn't released and thus creates a leak.I would think that
.ignoreContent
would do the work but it seems it doesn't: you have to read the incomingByteBuf
and release it manually. This can be somewhat problematic cause using that option, rather than doing aretain
where you want to use theByteBuf
, you need to do arelease
everywhere you do not want to use it.And here's a couple questions while i'm at it:
ignoreContent
have to be called every time you do not use it ?RequestHandler
have to return an Observable issued by one of theresponse
methods or would any observable do (evenObservable.empty
) ?Thanks
The text was updated successfully, but these errors were encountered: