Only trigger the timeoutScheduler when not yet subscribed. #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -273,7 +273,7 @@ public void onNext(T t) { | |||
| ReferenceCountUtil.retain(t); // Retain so that post-buffer, the ByteBuf does not get released. Release will be done after reading from the subject. | |||
| state.bufferedSubject.onNext(t); | |||
|
|
|||
| if (state.casTimeoutScheduled()) {// Schedule timeout once. | |||
| if (state.casTimeoutScheduled() && state.state == 0) {// Schedule timeout once and when not subscribed yet. | |||
There was a problem hiding this comment.
I think it's safer to do state.state == STATES.UNSUBSCRIBED.ordinal()
This smells like a race (as state can be changed concurrently) but the state does not change from SUBSCRIBED/DISPOSED to UNSUBSCRIBE so we are safe.
There was a problem hiding this comment.
Yup makes sense.. Do you have a hint on unit testing?
This changeset makes sure that the (costly) delayed execution task is schedule when noone is subscribed yet - since the whole purpose of its existence is to dispose if not subscribed yet. Note that a future improvement might be also to unsubscribe if one subscribes before the cleanup actually runs.
daschl
force-pushed
the
conditional-schedule
branch
from
6bbe554
to
3954a54
Compare
|
@NiteshKant good now? :) |
NiteshKant
added a commit
that referenced
this pull request
Jan 16, 2015
Only trigger the timeoutScheduler when not yet subscribed.
|
Yep, thanks @daschl ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset makes sure that the (costly) delayed execution task
is schedule when noone is subscribed yet - since the whole purpose
of its existence is to dispose if not subscribed yet.
Note that a future improvement might be also to unsubscribe if one
subscribes before the cleanup actually runs.
note that for some reason I couldn't get a valid unit test together (I didn't try very hard though). If you have any pointers on how to do it without changing too much let me know.