HttpServerRequest.getPath should only return path #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an absolute URI is passed in the request line, e.g.: ``` GET http://localhost:8090/hello HTTP/1.1 ``` Then the HttpServerRequest.getPath method was returning the full URI up to the query portion. If the user wanted the full URI they can call HttpServerRequest.getUri. It seems confusing to have getPath return the scheme and host. This change updates the UriInfoHolder used by HttpServerRequest to have getPath only return the path. Note, it does not use java.net.URI to do the parsing because it is strict and fails for many URIs that are common in practice, e.g. the URIs with `|` in the query.
NiteshKant
added a commit
that referenced
this pull request
Feb 9, 2015
HttpServerRequest.getPath should only return path
|
Thanks @brharrington ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an absolute URI is passed in the request line, e.g.:
Then the HttpServerRequest.getPath method was returning
the full URI up to the query portion. If the user wanted
the full URI they can call HttpServerRequest.getUri. It
seems confusing to have getPath return the scheme and
host.
This change updates the UriInfoHolder used by
HttpServerRequest to have getPath only return the path.
Note, it does not use java.net.URI to do the parsing because
it is strict and fails for many URIs that are common in
practice, e.g. the URIs with
|in the query.