Race condition in ClientRequestResponseConverter. #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For connection pool enabled clients, if the content unsubscription is delayed, it can get into a state where the connection is reused before unsubscription from content. In such a case, the content unsubscription will lead to connection closing, even when the connection is being used for another request. This also fixes a bug where a content dispose would end up closing the connection. The unsubscription action (closes connection) should not be called if there was no subscription.
NiteshKant
added a commit
that referenced
this pull request
Feb 11, 2015
Race condition in ClientRequestResponseConverter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For connection pool enabled clients, if the content unsubscription is delayed, it can get into a state where the connection is reused before unsubscription from content. In such a case, the content unsubscription will lead to connection closing, even when the connection is being used for another request.
This also fixes a bug where a content dispose would end up closing the connection. The unsubscription action (closes connection) should not be called if there was no subscription.