Errors in the pipeline post response header delivery were lost. #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 24, 2015 12:01
HttpClient response processing unsubscribes from the TCP connection input subject after the HTTP response headers are delivered. The errors were only trapped by the `ObservableAdapter` and forwarded to the subscriber of the input subject. In this case, since, the input subject is unsubscribed, the error does not get propagated to the subscriber of the `HttpClient.submit()`. This change makes `ClientRequestResponseConverter` intercept errors in the pipeline and propagate it to the subscriber of the response content.
NiteshKant
added a commit
that referenced
this pull request
Mar 24, 2015
Errors in the pipeline post response header delivery were lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpClient response processing unsubscribes from the TCP connection input subject after the HTTP response headers are delivered. The errors in the pipeline were only trapped by the
ObservableAdapterand forwarded to the subscriber of the input subject. In this case, since, the input subject is unsubscribed, the error does not get propagated to the subscriber of theHttpClient.submit().This change makes
ClientRequestResponseConverterintercept errors in the pipeline and propagate it to the subscriber of the response content.