Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behavior when exception occurs in onNext #192

Closed
mbonneau opened this issue Oct 26, 2017 · 1 comment · Fixed by #193
Closed

Change behavior when exception occurs in onNext #192

mbonneau opened this issue Oct 26, 2017 · 1 comment · Fixed by #193

Comments

@mbonneau
Copy link
Member

Right now if there is an exception in the onNext handler, it is possible that errors and exceptions get swallowed inside the library (or a promise from some other library).

The plan is to catch these and send them down the onError handler so that the user can see the problem.

Also, a default onError handler should be added that will log an error with the error information. This will help if users do not set the onError handler.

@davidwdan
Copy link
Member

Here is a discussion about RxJS, which suffers from the same issue:
ReactiveX/rxjs#2813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants