Merge f623c40 into 430cfab

.pre-commit-config.yaml

@@ -26,7 +26,7 @@ repos:
         language: node
         pass_filenames: false
         types: [python]
-        additional_dependencies: ["pyright@1.1.235"]
+        additional_dependencies: ["pyright@1.1.254"]
     repo: local
   - hooks:
       - id: mypy

reactivex/internal/utils.py

@@ -45,7 +45,7 @@ def alias(name: str, doc: str, fun: Callable[_P, _T]) -> Callable[_P, _T]:
     alias_.__kwdefaults__ = _fun.__kwdefaults__
     alias_.__doc__ = doc
     alias_.__annotations__ = _fun.__annotations__
-    return alias_
+    return cast(Callable[_P, _T], alias_)
 
 
 class NotSet:

reactivex/observable/fromfuture.py

@@ -38,7 +38,7 @@ def done(future: "Future[_T]") -> None:
         future.add_done_callback(done)
 
         def dispose() -> None:
-            if future and future.cancel:
+            if future:
                 future.cancel()
 
         return Disposable(dispose)

reactivex/operators/__init__.py

@@ -2559,7 +2559,7 @@ def scan(
 
 @overload
 def scan(
-    accumulator: Accumulator[_TState, _T], seed: _TState
+    accumulator: Accumulator[_TState, _T], seed: Union[_TState, Type[NotSet]]
 ) -> Callable[[Observable[_T]], Observable[_TState]]:
     ...
 

reactivex/operators/_groupbyuntil.py

@@ -119,7 +119,7 @@ def on_next(x: _T) -> None:
                     sad = SingleAssignmentDisposable()
                     group_disposable.add(sad)
 
-                    def expire():
+                    def expire() -> None:
                         if writers[key]:
                             del writers[key]
                             writer.on_completed()
@@ -134,12 +134,12 @@ def on_error(exn: Exception) -> None:
                             wrt.on_error(exn)
                         observer.on_error(exn)
 
-                    def on_completed():
+                    def on_completed() -> None:
                         expire()
 
-                    sad.disposable = duration.pipe(ops.take(1)).subscribe(
-                        on_next, on_error, on_completed, scheduler=scheduler
-                    )
+                    sad.disposable = duration.pipe(
+                        ops.take(1),
+                    ).subscribe(on_next, on_error, on_completed, scheduler=scheduler)
 
                 try:
                     element = element_mapper_(x)

reactivex/operators/_max.py

@@ -1,4 +1,4 @@
-from typing import Callable, Optional, TypeVar
+from typing import Callable, Optional, TypeVar, cast
 
 from reactivex import Observable, compose
 from reactivex import operators as ops
@@ -29,7 +29,7 @@ def max_(
         maximum element in the source sequence.
     """
     return compose(
-        ops.max_by(identity, comparer),
+        ops.max_by(cast(Callable[[_T], _T], identity), comparer),
         ops.map(first_only),
     )
 

reactivex/operators/_min.py

@@ -1,4 +1,4 @@
-from typing import Callable, List, Optional, TypeVar
+from typing import Callable, List, Optional, TypeVar, cast
 
 from reactivex import Observable, compose
 from reactivex import operators as ops
@@ -36,7 +36,7 @@ def min_(
         with the minimum element in the source sequence.
     """
     return compose(
-        ops.min_by(identity, comparer),
+        ops.min_by(cast(Callable[[_T], _T], identity), comparer),
         ops.map(first_only),
     )
 

reactivex/operators/_reduce.py

@@ -43,7 +43,7 @@ def reduce_(
         )
 
     return compose(
-        ops.scan(accumulator),
+        ops.scan(cast(Accumulator[_T, _T], accumulator)),
         ops.last(),
     )
 

reactivex/operators/_throttlefirst.py

@@ -13,7 +13,7 @@ def throttle_first_(
     def throttle_first(source: Observable[_T]) -> Observable[_T]:
         """Returns an observable that emits only the first item emitted
         by the source Observable during sequential time windows of a
-        specifiedduration.
+        specified duration.
 
         Args:
             source: Source observable to throttle.

reactivex/scheduler/mainloop/qtscheduler.py

@@ -28,8 +28,7 @@ def __init__(self, qtcore: Any):
         """
         super().__init__()
         self._qtcore = qtcore
-        timer_class: Any = self._qtcore.QTimer
-        self._periodic_timers: Set[timer_class] = set()
+        self._periodic_timers: Set[Any] = set()
 
     def schedule(
         self, action: typing.ScheduledAction[_TState], state: Optional[_TState] = None