Fix ConnectableObservable: scheduler is not forwarded

[jcafhe]

This PR fixes ConnectableObservable.connect(self, scheduler) method, where the source observable is not subscribed with the downstream subscribe scheduler.

I guess this is related to the fact that scheduler is a keyword argument only, so scheduler must be given as subscribe(observer, scheduler=scheduler), otherwise it will be dismissed.

A simple test case has been added.

This should fix some operators which are based on connect(scheduler) method like ref_count, and, by extension, to share. This should also fix #489.

[frederikaalund]

Fixes #489

[MainRo]

I guess this is related to the fact that scheduler is a keyword argument only, so scheduler must be given as subscribe(observer, scheduler=scheduler), otherwise it will be dismissed.

Yes, the second argument to the subscribe method is on_error. So scheduler has to be set with kw unless the 3 callbacks are provided before.

Nice!

[coveralls]

Coverage remained the same at 92.924% when pulling ee14b7c on jcafhe:fix-scheduler-ConnectableObservable into 5fc2cfb on ReactiveX:master.