Zip: completes as soon as any source completed #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MainRo
reviewed
Sep 4, 2020
MainRo
approved these changes
Sep 6, 2020
MainRo
added a commit
to MainRo/RxPY
that referenced
this pull request
Jan 22, 2022
The original fix for ReactiveX#525 breaks sequences where some observables emit item faster than other ones. By completing too soon, the remaining observables cannot catchup later. A very simple case is in ReactiveX#578 where the two observables to zip emit their items sequentially. We can fix both issues by completing whenever an observable completes and there is no queued item. Otherwise we let the remaining observables a chance to emit new items before completion.
MainRo
added a commit
that referenced
this pull request
Feb 6, 2022
The original fix for #525 breaks sequences where some observables emit items faster than other ones. By completing too soon, the remaining observables cannot catch up later. A very simple case is in #578 where the two observables to zip emit their items sequentially. We can fix both issues by completing whenever an observable completes and there is no queued item. Otherwise, we let the remaining observables a chance to emit new items before completion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #525