Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of misleading information in take_while documentation #596

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Removal of misleading information in take_while documentation #596

merged 2 commits into from
Feb 1, 2022

Conversation

kkonrad
Copy link
Contributor

@kkonrad kkonrad commented Jan 26, 2022

Small thing. Documentation was stating that element's index is used in logic of the predicate function which is not true for take_while operator

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.503% when pulling c89c5c4 on kkonrad:master into a4e84d8 on ReactiveX:master.

MainRo
MainRo approved these changes Feb 1, 2022
View reviewed changes
Copy link
Collaborator

@MainRo MainRo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MainRo MainRo merged commit c3cfd3d into ReactiveX:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MainRo MainRo MainRo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kkonrad @coveralls @MainRo