Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any python in the 3.x series >=3.7 #656

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Conversation

mmv
Copy link
Contributor

@mmv mmv commented Jul 12, 2022

Before converting from setup.py to pyproject, this upper bound didn't exist.

There's no reason to cap at 3.10. This breaks installations on other poetry projects defined with Python=^3.7 and would force updating this file for every new python version.

Before converting from setup.py, this upper bound didn't exist.

There's no reason to cap at 3.10. This breaks installations on other poetry projects defined with Python=^3.7 and would force updating this file for every new python version.
@dbrattli
Copy link
Collaborator

Instead of this I suggest that you change python-package.yaml to test specifically for a higher python version e.g 3.11.0-beta.4 so we know if it actually works or not. See https://github.com/actions/python-versions. Then we can change pyproject.toml to also include 3.11.

@dbrattli
Copy link
Collaborator

This makes me unsure if we should accept every new minor version: https://stackoverflow.com/questions/60421663/is-python-3-semantically-versioned-and-forwards-compatible. But I understand the frustration of not being able to use it if it actually works. Parts of me want to approve this PR 😄

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.375% when pulling 696fbc6 on mmv:patch-1 into 4d351c9 on ReactiveX:master.

Copy link
Collaborator

@dbrattli dbrattli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing

@dbrattli dbrattli merged commit 7187453 into ReactiveX:master Jul 16, 2022
@MainRo
Copy link
Collaborator

MainRo commented Jul 18, 2022

Thanks @dbrattli ! I also felt this restriction was... too restrictive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants