Add FutureToObservable #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoepelman
force-pushed
the
future_to_observable
branch
2 times, most recently
from
f7222b9
to
fd936e7
Compare
dhoepelman
changed the title
zsxwing
reviewed
Dec 26, 2016
| @deprecated("Use IterableToObservable", "0.26.5") | ||
| type ObservableExtensions[T] = IterableToObservable[T] | ||
|
|
||
| implicit class IterableToObservable[T](val iterable: Iterable[T]) extends AnyVal { |
There was a problem hiding this comment.
This actually will break binary compatibility. It's better to keep the class name and the parameter name because I think this implicit may be one of the most popular APIs.
There was a problem hiding this comment.
Ah oops, didn't think of binary comp
dhoepelman
force-pushed
the
future_to_observable
branch
from
fd936e7
to
e4acac4
Compare
dhoepelman
changed the title
|
@zsxwing Removed the |
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
FutureToObservableso allObservable.from(T)overloads have a matchingTToObservableRenamed
ObservableExtensionsto the more descriptiveIterableToObservable, which also makes the name in line withTryToObservableandOptionToObservable.