Changes return type of ignoreElements to Completable. #1436

ReactiveX · Oct 7, 2017 · 69ae352 · 69ae352
1 parent fe69f75
commit 69ae352
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/RxSwift/Observables/Filter.swift b/RxSwift/Observables/Filter.swift
@@ -32,10 +32,11 @@ extension ObservableType {
      - returns: An observable sequence that skips all elements of the source sequence.
      */
     public func ignoreElements()
-        -> Observable<E> {
-            return filter { _ -> Bool in
-                return false
+        -> Completable {
+            return flatMap { _ in
+                return Observable<Never>.empty()
             }
+            .asCompletable()
     }
 }
 

diff --git a/Tests/RxSwiftTests/Observable+FilterTests.swift b/Tests/RxSwiftTests/Observable+FilterTests.swift
@@ -233,7 +233,7 @@ extension ObservableFilterTest {
             ])
 
         let res = scheduler.start {
-            xs.ignoreElements()
+            (xs.ignoreElements() as Completable).asObservable()
         }
 
         XCTAssertEqual(res.events, [