Fixed issue with NSControl.rx.value multiple observers #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple observers want to look at NSControl.rx.value, only one would get updates because the returned observable wasn't shared(). This is examplified by the new test added to NSButton This also solves the issue of observers with varying types
Generated by 🚫 Danger |
9 tasks
kzaher
approved these changes
Sep 10, 2017
| .takeUntil((control as! NSObject).rx.deallocated) | ||
| .share(replay: 1, scope: .forever) | ||
| } | ||
| .map { [unowned control] _ in getter(control) } |
| .takeUntil((control as! NSObject).rx.deallocated) | ||
| } | ||
| .takeUntil((control as! NSObject).rx.deallocated) | ||
| .share(replay: 1, scope: .forever) |
There was a problem hiding this comment.
I think that this should be .whileConnected.
| return observer | ||
| } | ||
| .takeUntil((control as! NSObject).rx.deallocated) | ||
| } | ||
| .takeUntil((control as! NSObject).rx.deallocated) |
There was a problem hiding this comment.
Unfortunately for some reason still doesn't work with as control.rx.deallocated, have no idea why.
|
|
||
| XCTAssertEqual(button.state, NSControl.StateValue.on) | ||
| XCTAssertEqual(value1, NSControl.StateValue.on) | ||
| XCTAssertEqual(value2, NSControl.StateValue.on) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple observers want to look at NSControl.rx.value, only one would get updates because
the returned observable wasn't shared(). This is examplified by the new test added to NSButton
This also solves the issue of observers with varying types
Relates to issue #1398