Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename C to Collection, S to Sequence #1949

Merged
merged 4 commits into from
Apr 25, 2019
Merged

Rename C to Collection, S to Sequence #1949

merged 4 commits into from
Apr 25, 2019

Conversation

freak4pc
Copy link
Member

I'm pretty sure this will conflict as soon as you merge #1948 - so better to merge that one first since it's bigger.

@freak4pc freak4pc added the infra label Apr 24, 2019
@freak4pc freak4pc added this to the RxSwift 5 milestone Apr 24, 2019
@freak4pc freak4pc requested a review from kzaher April 24, 2019 19:48
@freak4pc freak4pc self-assigned this Apr 24, 2019
@freak4pc freak4pc changed the title Rename C generic constraint to Collection Rename C to Collection, S to Sequence Apr 24, 2019
@kzaher
Copy link
Member

kzaher commented Apr 25, 2019

Ah, damn it.

Just seen this PR :)

@freak4pc
Copy link
Member Author

No worries, I’ll rebase this ;-)

@freak4pc
Copy link
Member Author

Should be good to go @kzaher

@kzaher kzaher merged commit d4239bd into develop Apr 25, 2019
@freak4pc freak4pc deleted the c-to-collection branch April 25, 2019 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants