Fix iOS 13 UITableViewAlertForLayoutOutsideViewHierarchy warning

[ronzohan]

Fixes UITableViewAlertForLayoutOutsideViewHierarchy warning on iOS 13 by checking if layoutIfNeeded() needs to be called by performing a check if the object is currently attached to a window.

[ronzohan]

Fixes RxSwiftCommunity/RxDataSources#331

[marinh]

Any idea when this will be merged and released?

[SlashDevSlashGnoll]

@freak4pc Asked for Bumps on PRs that we find useful, so bumping here. Some of us really do like to keep our console logs clean of warnings so when problems really do occur we can notice them. I'd love to see this fix put in. Bug fixes are the best!

[freak4pc]

This seems like a good fix. @ronzohan mind rebasing on top of develop and adding a CHANGELOG entry?

[freak4pc]

Rebased and added a CHANGELOG entry for you. Thanks for your first contribution!

[svenmuennich]

Is there a reason why this change neither made it to master nor was part of any releases (5.1.0, 5.1.1) tagged since merging it?

[freak4pc]

Probably accidental, we need to cherry-pick it into develop.

[freak4pc]

I've cherry-picked this and it will be out on the next release, whichever that would be :)

[svenmuennich]

I've cherry-picked this and it will be out on the next release, whichever that would be :)

Great! Thank you 😃

[ameue]

I've cherry-picked this and it will be out on the next release, whichever that would be :)

I tried to use this method to test it with Xcode 11.5, iOS 13.5 Simulator. If you bind to viewDidLoad, you will still get the same warning when loading the page for the first time,

[freak4pc]

@ameue I just tried it on a branch and I'm not getting the warning as you do. (I linked my app to the develop branch of this repo).

Do you have a repro?

[ameue]

@ameue I just tried it on a branch and I'm not getting the warning as you do. (I linked my app to the develop branch of this repo).

Do you have a repro?

I try again, it works.

[MatrixSenpai]

Just wanted to update, I'm performing the following steps and still seeing the error from RxSwiftCommunity/RxDataSources#331

Using:

• CocoaPods
• branch develop

Steps:

• Pushing to a new view controller using RxFlow
• Creating a view controller using a combination of Reusable via ViewController.instantiate() and Storyboard
• Calling bind(to: ) in viewDidLoad()

I'm still seeing the Warning only once: UITableView was told to layout its visible cells... error

See this repo for a sample

[MatrixSenpai]

Just wanted to comment to make sure there's still attention brought to this issue. I'm still seeing it as of Swift 5.3 and RxSwift 5.0.1

Please reopen the related issue #2093 since this is still an issue.

This can cause serious issues with layout, especially when not using storyboards

[ronzohan]

Hi @MatrixSenpai , I believe this fix is not merged on RxSwift 5.0.1 but onto the next release version which would be on 6.0.0. You can try to use the 6.0.0 release candidate 6.0.0-rc.1 branch or the develop branch which contains the fix

As @freak4pc said,

I've cherry-picked this and it will be out on the next release, whichever that would be :)

[MatrixSenpai]

Will check out, ty for update