You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a setting to trigger a fatal error when a synchronization error is detected. The FATAL_SYNCHRONIZATION flag has precedence over this setting and it does not change the current default behavior.
Reasoning: We're trying to work through many synchronization errors in our app, but this process is going to take a while. In the meantime, we want to prevent new errors from being added to places that don't have them already. Our approach is to enable this setting for tests and provide a way to disable it for specific tests that currently have synchronization issues. One of the things we need for this to be possible is a way to turn this feature on or off easily.
This change introduces a setting to trigger a fatal error when a synchronization error is detected. The FATAL_SYNCHRONIZATION flag has precedence over this setting and it does not change the current default behavior.
Reasoning: We're trying to work through many synchronization errors in our app, but this process is going to take a while. In the meantime, we want to prevent new errors from being added to places that don't have them already. Our approach is to enable this setting for tests and provide a way to disable it for specific tests that currently have synchronization issues. One of the things we need for this to be possible is a way to turn this feature on or off easily.
I'm sorry for not replying so far, I guess you have worked around this in a different way but I'm wondering what's the reaosn to not add FATAL_SYNCHRONIZATION to your test suite directly, instead of an additional flag from the RxSwift side?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a setting to trigger a fatal error when a synchronization error is detected. The
FATAL_SYNCHRONIZATIONflag has precedence over this setting and it does not change the current default behavior.Reasoning: We're trying to work through many synchronization errors in our app, but this process is going to take a while. In the meantime, we want to prevent new errors from being added to places that don't have them already. Our approach is to enable this setting for tests and provide a way to disable it for specific tests that currently have synchronization issues. One of the things we need for this to be possible is a way to turn this feature on or off easily.