Provide Infallible versions of combineLatest without resultSelector requirement
#2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
freak4pc
reviewed
Apr 30, 2023
| @@ -29,6 +29,24 @@ extension Infallible { | |||
| } | |||
| } | |||
|
|
|||
| extension InfallibleType where Element == Any { | |||
There was a problem hiding this comment.
Is this constraint actually needed? Can't you just extend all InfallibleTypes ?
There was a problem hiding this comment.
@freak4pc Probably not, I just copied this from the Observable version, which has the constraint. Removing.
freak4pc
approved these changes
May 11, 2023
GalBerezansky
pushed a commit
to GalBerezansky/RxSwift
that referenced
this pull request
Jul 23, 2023
…eactiveX#2508) Co-authored-by: Shai Mishali <freak4pc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observablehas helper extensions forcombineLatestthat implement a basic defaultresultSelectorwhich makescombineLatestmuch more ergonomic to work with.This PR implements
Infallibleversions of these helpers.