Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisionOS Support #2564

Merged
merged 3 commits into from Apr 11, 2024
Merged

VisionOS Support #2564

merged 3 commits into from Apr 11, 2024

Conversation

nighthawk
Copy link
Contributor

@nighthawk nighthawk commented Dec 6, 2023

This PR adds support for visionOS to many more things by dropping a bunch of || os(visionOS) over the place.

Note of caution: While I'm using this in one app, and it's working fine there now, I have not tested everything that has been enabled here. However, as the visionOS SDK is still in beta that's probably not a big issue.

This fixes #2530, and is related to #2543.

@nighthawk
Copy link
Contributor Author

@freak4pc previously had to revert #2543, due to this:

Hey @RobertDresler - I had to revert this for now as this will cause build errors in Xcode 14.3 which is still a dominantly used Xcode version (which also requires users to update to Sonoma, which wasn't even officially released yet).

Sonoma and Xcode 15 are now releases. So this might be a good time now. Or feel free to keep this open until adoption of Sonoma is higher.

@notapplicableio
Copy link

As this is still Open does it mean that visionOS is not yet supported?

@notapplicableio
Copy link

@nighthawk do you know the timeframe for this getting merged?

@nighthawk
Copy link
Contributor Author

I'm not a maintainer of this project, so I can't answer that. @freak4pc might know.

FWIW, this is working fine in my usage so far and the changes are relatively straightforward.

Copy link
Member

@freak4pc freak4pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in merging, I'll try to get a few other fixes in and cut a release in a week or two.

@freak4pc freak4pc merged commit cf08cdc into ReactiveX:main Apr 11, 2024
4 checks passed
@nighthawk nighthawk deleted the visionOS branch April 11, 2024 22:20
@notapplicableio
Copy link

notapplicableio commented Apr 30, 2024

I have a little question about this @nighthawk. I'm sure it's environmental, but just in case...

I have updated to RxSwift 6.7.0 but it's not compiling on visionOS. Xcode claims to have 6.7.0 and I see evidence of your changes throughout, but not in Platform.Darwin.swift which is causing the compile issue.

I've done the usual; reset package cache, updated to latest, specific version, etc.

Am I going mad?

UPDATE: I looked a little harder and it hasn't made it to the main branch.

image

@freak4pc
Copy link
Member

freak4pc commented May 1, 2024

I have a little question about this @nighthawk. I'm sure it's environmental, but just in case...

I have updated to RxSwift 6.7.0 but it's not compiling on visionOS. Xcode claims to have 6.7.0 and I see evidence of your changes throughout, but not in Platform.Darwin.swift which is causing the compile issue.

I've done the usual; reset package cache, updated to latest, specific version, etc.

Am I going mad?

UPDATE: I looked a little harder and it hasn't made it to the main branch.

image

Darwin is Linux, is it actually trying to compile that file?

I had to remove it because it broke Linux / Unix builds

@nighthawk
Copy link
Contributor Author

@freak4pc Indeed, 6.7.0 doesn't actually compile for visionOS due to that change from #2589. visionOS does need that extension on Thread, too, as it's for example used in CurrentThreadScheduler.queue.

@freak4pc
Copy link
Member

freak4pc commented May 1, 2024

Seems this is only a waning and not an error, adding it back.

@freak4pc
Copy link
Member

freak4pc commented May 1, 2024

@notapplicableio Can you test the main branch to let me know if it fixes the issue?
If yes I'll cut a 6.7.1.
Thanks

@nighthawk
Copy link
Contributor Author

@freak4pc I just tested the latest main branch and it's compiling for visionOS again.

@freak4pc
Copy link
Member

freak4pc commented May 1, 2024

Release 6.7.1, thanks both!

@notapplicableio
Copy link

And for me, too. Thank you @freak4pc and @nighthawk :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

visionOS Compiling Error
3 participants