Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise 33: Drag contact offset #130

Merged
merged 1 commit into from
Jan 29, 2016
Merged

Exercise 33: Drag contact offset #130

merged 1 commit into from
Jan 29, 2016

Conversation

magus
Copy link
Contributor

@magus magus commented Jan 24, 2016

Add instead of subtract to get appropriate behavior (dragging on contact)

Currently the answer is incorrect and will result in the mouse dragging over whitespace.

Review on Reviewable

@mjomble mjomble mentioned this pull request Jan 29, 2016
@morenoh149
Copy link
Collaborator

@mjomble have you tested the PR?

@mjomble
Copy link
Contributor

mjomble commented Jan 29, 2016

Yes, fixed the problem in Chrome

morenoh149 added a commit that referenced this pull request Jan 29, 2016
Exercise 33: Drag contact offset
@morenoh149 morenoh149 merged commit 762e80a into ReactiveX:gh-pages Jan 29, 2016
@mjomble
Copy link
Contributor

mjomble commented Jan 29, 2016

Hmm, now that I retested it in live, it seems like the PR broke it and it was correct before.

The Run and Reset sprite buttons are a bit confusing and pressing them in the wrong order was probably what made it seem buggy in the first place.

If I understand correctly and the Reset sprite button only resets its location, perhaps the text on the button could be edited to make it clearer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants