Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding https support #355

Closed
snewell92 opened this issue Apr 19, 2017 · 13 comments
Closed

Adding https support #355

snewell92 opened this issue Apr 19, 2017 · 13 comments

Comments

@snewell92
Copy link

Get free ssl certificates by following these instructions, then set up the cronjob (or equivalent task scheduler) to run the cerbot once or twice a day, and then you have free ssl 5evr, which is one more than forever.

Thanks for reading!

@snewell92
Copy link
Author

This is probably related to #307 - which might be out of date.

@NZSmartie
Copy link

Github pages doesn't support HTTPS for custom domains. (See https://help.github.com/articles/securing-your-github-pages-site-with-https/)
The next best approach is to use a 3rd party like Cloudflare (Here's a guide)

@snewell92
Copy link
Author

Ah, right you are.

@preco21
Copy link

preco21 commented May 1, 2018

FYI: I think this could finally be done with this announcement. GitHub is moving forward to support https for custom domains with Let’s Encrypt.

Maybe reopening this issue again?

@snewell92
Copy link
Author

Nice!

@snewell92 snewell92 reopened this May 2, 2018
@oboukli
Copy link

oboukli commented Jun 8, 2018

Any update on this issue?

@simonbasle
Copy link

the HTTPS certificate is still flagged as insecure due to using a certificate delivered to github.com.
Maybe A DNS records are used? There is a guide on how to configure HTTPS in that later case at https://help.github.com/en/articles/troubleshooting-custom-domains#https-errors

@oboukli
Copy link

oboukli commented Jun 20, 2019

To whom it may concern: https://doesmysiteneedhttps.com/

@r3h0
Copy link
Contributor

r3h0 commented Oct 9, 2021

From a quick search and a dig reactivex.io, I suspect this mostly requires the reactivex.io domain admin to change the A-record IP addresses, but I wasn't able to identify the owner of the domain.

@crstalli
Copy link

crstalli commented Nov 1, 2021

So from whois, it looks like @benjchristensen, or at least he should know who does own this domain. We better find out soon because the Registry Expiry Date: 2022-01-04T01:45:54Z is fast approaching.

@benjchristensen
Copy link
Member

I have updated the DNS records and it seems https://reactivex.io is now working. Please verify.

@crstalli
Copy link

crstalli commented Nov 2, 2021

Thanks Ben! This issue can probably be closed, although it doesn't by default redirect you to https. We aren't enforcing so I may create a new issue that allows us to do that. You can still navigate to the page via http if you type it in or have a link. I believe the link below either enforces it, or redirects if you don't use https.

https://docs.github.com/en/pages/getting-started-with-github-pages/securing-your-github-pages-site-with-https

@akarnokd
Copy link
Member

Closing as https://reactivex.io/ is confirmed working. I also enabled "Enforce HTTPS" on the repo and http://reactivex.io should redirect properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants