Update Dockerfile to use jekyll:3.8 #399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jekyll 4.0 dropped support for redcarpet which is currently used as the markdown parser. jekyll/jekyll#7838
|
LGTM. These days I normally set image tags to something more specific than latest. I'm not a maintainer, so I can't merge the PR. |
|
cc @DavidMGross, any chance we can get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jekyll 4.0 dropped support for redcarpet which is currently used
as the markdown parser.
jekyll/jekyll#7838
It may be better to migrate to jekyll:4 in the future, but this gets
the Dockerfile back into a working state.
Fixes #400