Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tslint 6.x #72

Open
rooby opened this issue Jan 5, 2021 · 4 comments
Open

Add support for tslint 6.x #72

rooby opened this issue Jan 5, 2021 · 4 comments

Comments

@rooby
Copy link

rooby commented Jan 5, 2021

Currently the peer dependency of tslint: ^5.0.0 means you get this warning when using tslint 6.x

npm WARN rxjs-tslint@0.1.8 requires a peer of tslint@^5.0.0 but none is installed. You must install peer dependencies yourself.

Can support for 6.x be added?

@joshuakeel
Copy link

I just ran into this as well, when updating to Angular 10.

@joboyx
Copy link

joboyx commented Jan 20, 2021

Same with me, I've encountered this when running Angular v11 upgrade:

$ ng update @angular/core @angular/cli
Using package manager: 'npm'
Collecting installed dependencies...
Found 66 dependencies.
Fetching dependency metadata from registry...
                  Package "rxjs-tslint" has an incompatible peer dependency to "tslint" (requires "^5.0.0", would install "6.1.3").
✖ Migration failed: Incompatible peer dependencies found.
Peer dependency warnings when installing dependencies means that those dependencies might not work correctly together.
You can use the '--force' option to ignore incompatible peer dependencies and instead address these warnings later.
  See "/tmp/ng-ABeah5/angular-errors.log" for further details.

have you tried to force (--force) and ignore the peer dependency warning? Would there be issues?

@rooby
Copy link
Author

rooby commented Feb 15, 2021

@rooby Yep, I'm currently doing that and haven't had any issues.

@madhukudala
Copy link

image

I got the same issue. Because of this issue, I am unable to update the angular version from 10 to 11. Is there any solution to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants