Skip to content

Commit

Permalink
fix(lint_perf): fix lint issues with newer perf tests
Browse files Browse the repository at this point in the history
  • Loading branch information
benlesh committed Mar 30, 2018
1 parent 55296c9 commit 1013754
Show file tree
Hide file tree
Showing 5 changed files with 41 additions and 39 deletions.
16 changes: 8 additions & 8 deletions perf/micro/current-thread-scheduler/subject/replaysubject.js
Expand Up @@ -6,12 +6,12 @@ module.exports = function (suite) {
var newRangeWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.queue);

return suite
.add('old ReplaySubject with immediate scheduler', function () {
var subject = new RxOld.ReplaySubject(5, Number.POSITIVE_INFINITY, RxOld.Scheduler.currentThread);
oldRangeWithCurrentThreadScheduler.subscribe(subject);
})
.add('new ReplaySubject with immediate scheduler', function () {
var subject = new RxNew.ReplaySubject(5, Number.POSITIVE_INFINITY, RxNew.Scheduler.queue);
newRangeWithCurrentThreadScheduler.subscribe(subject);
});
.add('old ReplaySubject with immediate scheduler', function () {
var subject = new RxOld.ReplaySubject(5, Number.POSITIVE_INFINITY, RxOld.Scheduler.currentThread);
oldRangeWithCurrentThreadScheduler.subscribe(subject);
})
.add('new ReplaySubject with immediate scheduler', function () {
var subject = new RxNew.ReplaySubject(5, Number.POSITIVE_INFINITY, RxNew.Scheduler.queue);
newRangeWithCurrentThreadScheduler.subscribe(subject);
});
};
Expand Up @@ -6,12 +6,12 @@ module.exports = function (suite) {
var newRangeWithCurrentThreadScheduler = RxNew.Observable.range(0, 25, RxNew.Scheduler.queue);

return suite
.add('old ReplaySubject with immediate scheduler', function () {
var subject = new RxOld.ReplaySubject(5, 50, RxOld.Scheduler.currentThread);
oldRangeWithCurrentThreadScheduler.subscribe(subject);
})
.add('new ReplaySubject with immediate scheduler', function () {
var subject = new RxNew.ReplaySubject(5, 50, RxNew.Scheduler.queue);
newRangeWithCurrentThreadScheduler.subscribe(subject);
});
.add('old ReplaySubject with immediate scheduler', function () {
var subject = new RxOld.ReplaySubject(5, 50, RxOld.Scheduler.currentThread);
oldRangeWithCurrentThreadScheduler.subscribe(subject);
})
.add('new ReplaySubject with immediate scheduler', function () {
var subject = new RxNew.ReplaySubject(5, 50, RxNew.Scheduler.queue);
newRangeWithCurrentThreadScheduler.subscribe(subject);
});
};
16 changes: 9 additions & 7 deletions perf/micro/immediate-scheduler/operators/buffertime.js
Expand Up @@ -2,17 +2,19 @@ var RxOld = require('rx');
var RxNew = require('../../../../index');

module.exports = function (suite) {
var oldBufferWithImmediateScheduler = RxOld.Observable.interval(25, RxOld.Scheduler.immediate).bufferWithTime(60, RxOld.Scheduler.immediate).take(3);
var oldBufferWithImmediateScheduler =
RxOld.Observable.interval(25, RxOld.Scheduler.immediate)
.bufferWithTime(60, RxOld.Scheduler.immediate).take(3);
var newBufferWithImmediateScheduler = RxNew.Observable.interval(25).bufferTime(60).take(3);

function _next(x) { }
function _error(e) { }
function _complete() { }
return suite
.add('old bufferTime() with immediate scheduler', function () {
oldBufferWithImmediateScheduler.subscribe(_next, _error, _complete);
})
.add('new bufferTime() with immediate scheduler', function () {
newBufferWithImmediateScheduler.subscribe(_next, _error, _complete);
});
.add('old bufferTime() with immediate scheduler', function () {
oldBufferWithImmediateScheduler.subscribe(_next, _error, _complete);
})
.add('new bufferTime() with immediate scheduler', function () {
newBufferWithImmediateScheduler.subscribe(_next, _error, _complete);
});
};
16 changes: 8 additions & 8 deletions perf/micro/immediate-scheduler/subject/replaysubject.js
Expand Up @@ -6,12 +6,12 @@ module.exports = function (suite) {
var newRangeWithImmediateScheduler = RxNew.Observable.range(0, 25);

return suite
.add('old ReplaySubject with immediate scheduler', function () {
var subject = new RxOld.ReplaySubject(5, Number.POSITIVE_INFINITY, RxOld.Scheduler.immediate);
oldRangeWithImmediateScheduler.subscribe(subject);
})
.add('new ReplaySubject with immediate scheduler', function () {
var subject = new RxNew.ReplaySubject(5, Number.POSITIVE_INFINITY);
newRangeWithImmediateScheduler.subscribe(subject);
});
.add('old ReplaySubject with immediate scheduler', function () {
var subject = new RxOld.ReplaySubject(5, Number.POSITIVE_INFINITY, RxOld.Scheduler.immediate);
oldRangeWithImmediateScheduler.subscribe(subject);
})
.add('new ReplaySubject with immediate scheduler', function () {
var subject = new RxNew.ReplaySubject(5, Number.POSITIVE_INFINITY);
newRangeWithImmediateScheduler.subscribe(subject);
});
};
Expand Up @@ -6,12 +6,12 @@ module.exports = function (suite) {
var newRangeWithImmediateScheduler = RxNew.Observable.range(0, 25);

return suite
.add('old ReplaySubject with immediate scheduler', function () {
var subject = new RxOld.ReplaySubject(5, 50, RxOld.Scheduler.immediate);
oldRangeWithImmediateScheduler.subscribe(subject);
})
.add('new ReplaySubject with immediate scheduler', function () {
var subject = new RxNew.ReplaySubject(5, 50);
newRangeWithImmediateScheduler.subscribe(subject);
});
.add('old ReplaySubject with immediate scheduler', function () {
var subject = new RxOld.ReplaySubject(5, 50, RxOld.Scheduler.immediate);
oldRangeWithImmediateScheduler.subscribe(subject);
})
.add('new ReplaySubject with immediate scheduler', function () {
var subject = new RxNew.ReplaySubject(5, 50);
newRangeWithImmediateScheduler.subscribe(subject);
});
};

0 comments on commit 1013754

Please sign in to comment.