Skip to content

Commit

Permalink
Merge 09100ab into a9c87f6
Browse files Browse the repository at this point in the history
  • Loading branch information
edenhermelin committed Apr 21, 2019
2 parents a9c87f6 + 09100ab commit f34f633
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 1 deletion.
7 changes: 7 additions & 0 deletions .dockerignore
@@ -0,0 +1,7 @@
node_modules
npm-debug.log
Dockerfile*
docker-compose*
.dockerignore
.git
.gitignore
14 changes: 14 additions & 0 deletions Dockerfile
@@ -0,0 +1,14 @@
FROM node:latest

# Create app directory
WORKDIR /rxjs

COPY . .

WORKDIR /rxjs/docs_app

RUN npm run setup

EXPOSE 4200

CMD ["npm", "start"]
8 changes: 8 additions & 0 deletions docs_app/README.md
Expand Up @@ -36,6 +36,14 @@ Running `npm run start` (even when explicitly targeting production mode) does no
ServiceWorker. If you want to test the ServiceWorker locally, you can use `npm run build` and then
serve the files in `dist/` with `npm run http-server -- dist -p 4200`.

## Running on Docker

The docs app (rxjs.io) can run as a docker container.
In order to run the docs app on docker, use the following commands (**run from the rxjs folder**):
* `docker build -t rxjs-docs:6.4.1 .` - building the rxjs docs app image
* `docker run -p <host-port>:4200 rxjs-docs:6.4.1` - starting the container, listening on *<host-port>* for your choice.
> tested on ubuntu 18.04.2 with Docker 18.09.4
## Guide to authoring

There are two types of content in the documentation:
Expand Down
2 changes: 1 addition & 1 deletion docs_app/package.json
Expand Up @@ -9,7 +9,7 @@
"postinstall": "uglifyjs node_modules/lunr/lunr.js -c -m -o src/assets/js/lunr.min.js --source-map",
"ng": "ng",
"firebase": "firebase",
"start": "ng serve --configuration=fast",
"start": "ng serve --configuration=stable --host 0.0.0.0",
"setup": "npm install && npm run ~~clean-generated && npm run build-ie-polyfills && npm run docs",
"prebuild": "npm run setup",
"build": "npm run ~~build",
Expand Down

0 comments on commit f34f633

Please sign in to comment.