Subject.onNext not a function?

[thunderkid]

I'm trying to get Rx Subjects to work following the RxJs docs. I'm using:

    import * as Rx from 'rxjs';
    var subject = new Rx.Subject();

    var subscription = subject.subscribe(
        function (x) {
            console.log('Next: ' + x);
        },
        function (err) {
            console.log('Error: ' + err);
        },
        function () {
            console.log('Completed');
        });

    subject.onNext(42);

But typescript tells me onNext is not a function, and if I force it with subject:any, the browser also tells me subject.onNext is not a function. Has the syntax changed?

[benlesh]

Due to changes to accommodate the ES7 Observable spec, the API has changed for observables:

• onNext -> next
• onError -> error
• onCompleted -> complete

I apologize for any confusion. We're working on a migration strategy (probably documentation) to land during the early stages of beta.

[benlesh]

@thunderkid I'm going to close this one for now, as it's not a bug, and I hope that my previous comment addresses your concerns.

[thunderkid]

Yes, that fixed it. Thanks. (btw I also noticed bufferWithTime doesn't seem to be there. I'm assuming it's been replaced with bufferTime.)

[benlesh]

@thunderkid ... made this today... just for you: https://github.com/ReactiveX/RxJS/blob/master/MIGRATION.md

;)

It's a first go, so I expect it will be improved over the next month or so.

[thunderkid]

Brilliant, thanks. That'll remove a bit of guesswork. What's the eta of the 5.0 stable release?

[dholth]

I didn't realize https://github.com/Reactive-Extensions/RxJS/blob/master/doc/api/subjects/subject.md was a different thing than this one, the former has better Google-Fu.

[KunmyonChoi]

Do you guys have a plan to give a hint on this document?
https://github.com/Reactive-Extensions/RxJS/blob/master/doc/api/core/observer.md

[kwonoj]

@KunmyonChoi it already does. https://github.com/ReactiveX/rxjs/blob/master/MIGRATION.md#observer-interface-changes-also-subjects . Please note given repo is for RxJS v4, does not contain v5 related changes.

[ORESoftware]

oh shit I thought it was completed instead of complete, d'oh!

[ORESoftware]

honestly, I think it would just be better to alias all of them with the old method names, dunno though

[clembu]

@ORESoftware that would really confuse newcomers. Starting working with a library that's a rewrite of an old one means not dealing with the old one at all. It's a complete rewrite, meaning it's not the same thing, meaning don't get their APIs mingled.
You should never take your knowledge for granted when you change major versions of a dependency.

[ORESoftware]

@FacelessPanda I am not a huge fan of aliasing, for many reasons, but in this case these methods will never change purpose, so onNext and next should do the same thing, it would be hugely convenient to just make onNext an alias of next, etc.

I don't see how it would be confusing to newcomers. All the documentation would point to the new methods, without any mention of the old. If someone forgets somewhere deep in a codebase to change onNext to next, then it will be simply convenient.

The change from onNext to next is not about breaking changes, it's about conforming to the ES7 spec, so it's really just not necessary to creating breaking changes when you're just renaming things. This is a case where aliasing would actually be just straight up a good thing.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.