Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compatibility] forEach test case fails on firefox #1451

Closed
kwonoj opened this issue Mar 10, 2016 · 1 comment · Fixed by #1452
Closed

[Compatibility] forEach test case fails on firefox #1451

kwonoj opened this issue Mar 10, 2016 · 1 comment · Fixed by #1452

Comments

@kwonoj
Copy link
Member

kwonoj commented Mar 10, 2016

RxJS version:
master

Actual behavior:
one of forEach test case fails on firefox, async test completion callback does not called in time.

Observable forEach should handle an asynchronous throw from the next handler and tear down FAILED
    Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL. in /home/travis/build/ReactiveX/RxJS/node_modules/jasmine-core/lib/jasmine-core/jasmine.js (line 1909)
    attemptAsync/timeoutId<@/home/travis/build/ReactiveX/RxJS/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1909:23

need additional triage if this is simply test case design issue, or related with actual operator behavior.

Additional information:

Occurs on firefox 42 / 45. Log can be found at https://travis-ci.org/ReactiveX/RxJS/builds/114986963
kwonoj added a commit to kwonoj/rxjs that referenced this issue Mar 10, 2016
@kwonoj
test(forEach): update browser compatibility
3b5453b 
- provide delay to setInterval() in test specs to ensure call executes repeatedly

closes ReactiveX#1451
@kwonoj kwonoj mentioned this issue Mar 10, 2016
Merged
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(forEach): update browser compatibility kwonoj/rxjs
1 participant
@kwonoj