Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refCount.js is blocked by ad blockers #3033

Closed
Yoten opened this issue Nov 1, 2017 · 6 comments
Closed

refCount.js is blocked by ad blockers #3033

Yoten opened this issue Nov 1, 2017 · 6 comments

Comments

@Yoten
Copy link

Yoten commented Nov 1, 2017

RxJS version:
5.5.2

Code to reproduce:
N/A

Expected behavior:
All files should load as expected

Actual behavior:
"operators/refCount.js" is blocked by the "EasyPrivacy" 3rd-party list used by default by ad blockers such as uBlock Origin, causing fetch errors when other files such as "share.js" depend on it.

Additional information:
Screenshot of fetch error & uBlock Origin entry:

blocked

I realize this is more of an issue of EasyPrivacy needing to tweak their filters rather than an RXJS problem, but this seems severe enough that I'm surprised I haven't been able to find anyone else talking about it.

@kwonoj
Copy link
Member

kwonoj commented Nov 1, 2017

This feels super weird, our refCount impl doesn't do any network request and any ad-related (of course). Is it able to find reason why it's blocked? without knowing reason I don't know what can we do from our end.

@Yoten
Copy link
Author

Yoten commented Nov 1, 2017

My best guess is that some kind of tracking script/cookie/etc. is using the name "refcount" in one of their files and that's what got the name added to the anti-privacy list. It's not that they're specifically blocking RXJS's refCount.js, but that the name "refcount.*" in general is blocked -- the filter is set too vaguely.

I don't think there's anything you guys need to do on your end code-wise, but it might be worth posting on the EasyList forums and asking if they can change the filter on their end to prevent this false positive:

https://forums.lanik.us/viewforum.php?f=64

@kwonoj
Copy link
Member

kwonoj commented Dec 4, 2017

I don't think there's much actionable on our end, closing issue for now. ad blockers should correct their listing mechanism.

@kwonoj kwonoj closed this as completed Dec 4, 2017
@JoshKisb
Copy link

JoshKisb commented Jan 1, 2018

How about just changing the name?

@trahloff
Copy link

trahloff commented Jan 8, 2018

Could you guys please just rename it?
Being blocked by an AdBlocker is a serious business hazard for a company.
I just came here because a client phoned me...

EDIT: Here is the link to the discussion over at the EasyList forum but I'm quite sure that they won't remove refCount from their list...

mapx- added a commit to uBlockOrigin/uAssets that referenced this issue Feb 5, 2018
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants