You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current Behavior
Have updated my app from Angular 5 to 6.
By following the steps on https://update.angular.io/ - I have dealt with RxJs code changes e.g. imports, pipes etc. following the rxjs-tslint instructions.
After the Update
Remove deprecated RxJS 6 features using rxjs-tslint auto update rules.
For most applications this will mean running the following two commands:
`yarn global add rxjs-tslint`
`rxjs-5-to-6-migrate -p src/tsconfig.app.json`
Once you and all of your dependencies have updated to RxJS 6, remove rxjs-compat.
I remove rxjs-compat as instructed but RxJS relies on it. It should not?
Another issue is my tests do not run due to the rxjs-compat issue, it seems:
ERROR in node_modules/rxjs/Observable.d.ts(1,15): error TS2307: Cannot find module 'rxjs-compat/Observable'.
03 08 2018 14:41:28.976:WARN [karma]: No captured browser, open http://localhost:9876/
03 08 2018 14:41:28.983:INFO [karma]: Karma v2.0.5 server started at http://0.0.0.0:9876/
03 08 2018 14:41:28.983:INFO [launcher]: Launching browser Chrome with unlimited concurrency
03 08 2018 14:41:29.015:INFO [launcher]: Starting browser Chrome
03 08 2018 14:41:30.033:INFO [Chrome 67.0.3396 (Mac OS X 10.13.4)]: Connected on socket s44qFd54EqfF9utgAAAA with id 77754672
Chrome 67.0.3396 (Mac OS X 10.13.4): Executed 0 of 0 ERROR (0.001 secs / 0 secs)
Expected behavior
Do not have RxJs rely on rxjs-compat or have a version that does not for those who are fixing their code early.
Apparently, the tslint migration you ran didn't catch everything. If you're seeing that error, it's because you're importing from rxjs/Observable somewhere. That will cause rxjs to try to use rxjs-compat.
If you're getting notifications that you need rxjs-compat, it's because you're importing from somewhere that's not rxjs, rxjs/operators, rxjs/webSocket, rxjs/ajax or rxjs/testing.
I'm going to close this issue for now, but if you need further assistance let us know!
Hi @benlesh - as mentioned above, I am running the rxjs-tslint on my code and all is well.
Also I have checked all my rxjs imports and they all look right from what I know at this point.
So I would like to respectfully challenge this issue being closed.
lockbot
locked as resolved and limited conversation to collaborators
Sep 8, 2018
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug Report
Current Behavior
Have updated my app from Angular 5 to 6.
By following the steps on https://update.angular.io/ - I have dealt with RxJs code changes e.g. imports, pipes etc. following the rxjs-tslint instructions.
After the Update
I remove rxjs-compat as instructed but RxJS relies on it. It should not?
Another issue is my tests do not run due to the rxjs-compat issue, it seems:
Expected behavior
Do not have RxJs rely on rxjs-compat or have a version that does not for those who are fixing their code early.
Environment
package.json
Possible Solution
Remove the dependency on
rxjs-compat
.Versions
The text was updated successfully, but these errors were encountered: