Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs]: refCount is not an method #4664

Closed
1 of 5 tasks
ghost opened this issue Mar 25, 2019 · 0 comments · Fixed by #4774
Closed
1 of 5 tasks

[docs]: refCount is not an method #4664

ghost opened this issue Mar 25, 2019 · 0 comments · Fixed by #4774
Labels
docs Issues and PRs related to documentation

Comments

@ghost
Copy link

ghost commented Mar 25, 2019 •
edited by ghost

Documentation Related To Component:

https://github.com/ReactiveX/rxjs/blob/master/doc/subject.md#reference-counting

Please check those that apply

  • typo
  • documentation doesn't exist
  • documentation needs clarification
  • error(s) in example
  • needs example

Description Of The Issue

It says that refCount() is only a method that only exists on ConnectedObservable, but since 6.0, it's an operator.
@ghost ghost changed the title refCount is not an method [docs]: refCount is not an method Mar 25, 2019
@niklas-wortmann niklas-wortmann added the docs Issues and PRs related to documentation label Mar 28, 2019
natmegs added a commit to natmegs/rxjs that referenced this issue May 11, 2019
@natmegs
docs(subject.md): clarify that refCount is an operator
fdebb6c 
Clarify that refCount is an operator and not a method used directly on a ConnectableObservable.

Closes ReactiveX#4664
@natmegs natmegs mentioned this issue May 11, 2019
Merged
benlesh pushed a commit that referenced this issue Jun 5, 2019
@natmegs @benlesh
docs(subject.md): clarify that refCount is an operator (#4774)
307984f 
Clarify that refCount is an operator and not a method used directly on a ConnectableObservable.

Closes #4664
benlesh pushed a commit that referenced this issue Jun 5, 2019
@natmegs @benlesh
docs(subject.md): clarify that refCount is an operator (#4774)
e4f2d23 
Clarify that refCount is an operator and not a method used directly on a ConnectableObservable.

Closes #4664
@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
docs Issues and PRs related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(subject.md): clarify that refCount is an operator natmegs/rxjs
1 participant
@niklas-wortmann