Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Operator Decision Tree for switchMap #5154

Closed
1 of 5 tasks
Trildar opened this issue Nov 20, 2019 · 9 comments
Closed
1 of 5 tasks

Error in Operator Decision Tree for switchMap #5154

Trildar opened this issue Nov 20, 2019 · 9 comments
Labels
docs Issues and PRs related to documentation help wanted Issues we wouldn't mind assistance with.

Comments

@Trildar
Copy link

Trildar commented Nov 20, 2019

Documentation Related To Component:

Operator Decision Tree

Please check those that apply

  • typo
  • documentation doesn't exist
  • documentation needs clarification
  • error(s) in example
  • needs example

Description Of The Issue

The Operator Decision Tree relating to switchMap appears to have some issue. It recommends exhaustMap before actually hitting a leaf node and is missing the option for "where the nested Observable is the same for every value". The below screenshot should clarify what I mean.
image

@cartant cartant added docs Issues and PRs related to documentation help wanted Issues we wouldn't mind assistance with. labels Nov 20, 2019
@dzhavat
Copy link
Contributor

dzhavat commented Nov 29, 2019

Just tried to recreate this. I started the docs locally and this is what I get when I navigate to the same step:

image

Can it be that the issue has already been fixed but it's still not deployed yet?

@Fallenstedt
Copy link

@jsonberry I think you worked on this right?

@jsonberry
Copy link
Contributor

jsonberry commented Dec 6, 2019 via email

@dzhavat
Copy link
Contributor

dzhavat commented Dec 27, 2019

@Trildar the docs were updated earlier today. Can you check if you still get that error? :)

@jsonberry
Copy link
Contributor

On version 6.5.5-local+sha.7e4589a1 of the docs released to prod I'm unable to reproduce the bug, poked around a bit on it and haven't seen any issues.
RxJS

@dzhavat
Copy link
Contributor

dzhavat commented Jan 9, 2020

If that's the case, can the issue be closed?

@Trildar
Copy link
Author

Trildar commented Jan 9, 2020

Hi, sorry, forgot to check on this. Seems fine checking on my phone, albeit that's not what I used when I noticed the issue. Will try to check on that if I remember.

@Trildar
Copy link
Author

Trildar commented Jan 13, 2020

Checked on the platform where I first encountered the issue. Seems to be fixed. Though I did have to reload the page once, likely due to cache.

@dzhavat
Copy link
Contributor

dzhavat commented Jan 13, 2020

In that case the issue can be closed :)

@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Issues and PRs related to documentation help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Development

No branches or pull requests

6 participants