Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7 breaking changes guide is missing notes about debounce #6298

Closed
OliverJAsh opened this issue Apr 30, 2021 · 2 comments
Closed

v7 breaking changes guide is missing notes about debounce #6298

OliverJAsh opened this issue Apr 30, 2021 · 2 comments
Labels
docs Issues and PRs related to documentation

Comments

@OliverJAsh
Copy link
Contributor

The changelog describes a breaking change to debounce but this is not mentioned in the guide.

https://github.com/ReactiveX/rxjs/blob/master/CHANGELOG.md#:~:text=debounce%3A%20the%20observable%20returned%20by%20the%20debounce%20

debounce: the observable returned by the debounce operator's duration selector must emit a next notification to end the duration. Complete notifications no longer end the duration.

This broke our application in a non-trivial way so I think it's worth mentioning in the guide. WDYT?

@cartant
Copy link
Collaborator

cartant commented Apr 30, 2021

Yes. That's an oversight. And it's not just that operator. All notifiers now have to emit a next notification.

@cartant cartant added the docs Issues and PRs related to documentation label Apr 30, 2021
cartant added a commit to cartant/rxjs that referenced this issue Apr 30, 2021
@cartant
Copy link
Collaborator

cartant commented Apr 30, 2021

I've opened two PRs that bring all of the v7 breaking changes listed in the CHANGELOG into the summary document. Thanks for opening the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and PRs related to documentation
Projects
None yet
Development

No branches or pull requests

2 participants