fix(ScalarObservable): remove ScalarObservable optimization #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove usage of ScalarObservable for optimization - implementation of ScalarObservable still remain for possible further usage closes ReactiveX#1142, ReactiveX#1150, ReactiveX#1140
|
I think the idea was to remove the optimization from ScalarObservable, not to remove ScalarObservable itself (I might be reading Ben wrong though). I can imagine there are performance benefits in keeping ScalarObservable. At least I think #1142 is only about removing the eager optimizations from ScalarObservable, not removing itself from FromObservable e.g. |
|
Ah, seems I was in hurry and did not get point correctly. Thanks for pointing out, @staltz . Let me close this, if this is really considerable can be reopened later. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1142, #1150, #1140
Created PR, though it's bit early to get conclusion. Can be closed if it's decided to use ScalarObservable.
This PR removes usage of
ScalarObservablefrom operators, but remain implementation itself for possible further discussions around optimizations when it's required.