Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Scheduler): clearify the signature which Scheduler.schedule() takes as work. #2078

Merged
merged 1 commit into from
Nov 4, 2016
Merged

refactor(Scheduler): clearify the signature which Scheduler.schedule() takes as work. #2078

merged 1 commit into from
Nov 4, 2016

Commits on Oct 27, 2016

  1. refactor(Scheduler): clearify the signature which `Scheduler.schedule… 

    …()` takes as `work`.

I think this would not be a breaking change by these reasons:

- There are no problem if we pass the function which does not has `this` specifying.
- There are no problem if we pass the function which has `this: any` or `this: Action<T>`.
  - This case is valid with the actual behavior.
- If we pass the function which has `this: SomeNonValidTypeWithAction<T>`,
  then, basically, its code would be wrong.
    @tetsuharuohzeki
    tetsuharuohzeki committed Oct 27, 2016
    Configuration menu
    Copy the full SHA
    124a048 View commit details
    Browse the repository at this point in the history