chore(package.json): clear up intermidiate build artifact after build #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm feeling bulid script might need to be simplified (and remove some of confusions if anyone read scripts).. but that's other story later. |
jayphelps
reviewed
Dec 20, 2016
| "build_perf": "webdriver-manager update && npm-run-all build_cjs build_global perf", | ||
| "build_test": "shx rm -rf ./dist/ && npm-run-all build_cjs clean_spec build_spec test_mocha", | ||
| "build_cover": "shx rm -rf ./dist/ && npm-run-all build_cjs build_spec cover", | ||
| "build_docs": "npm-run-all build_global build_es6_for_docs build_cjs clean_spec build_spec tests2png decision_tree_widget && esdoc -c esdoc.json", | ||
| "build_docs": "npm-run-all build_global build_es6_for_docs build_cjs clean_spec build_spec decision_tree_widget && esdoc -c esdoc.json && npm-run-all clean_dist_es6", |
There was a problem hiding this comment.
should tests2png have been kept? By removing it here, it's no longer used in any other script and I think it is indeed needed as part of the doc building process?
There was a problem hiding this comment.
OH NO 😱 my bad, I was removing it to test script without png generation tools setup.
kwonoj
force-pushed
the
fix-es6-build
branch
from
077cc2e
to
3a59884
Compare
|
Updated PR corrects my error. |
|
Seems good, but I want @Blesh to confirm as well. |
|
@jayphelps I agree. |
|
LGTM |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR makes force clear intermediate build artifact
es6used for internal doc / umd package building only, to no longer included in actualRelated issue (if exists):
#2177