fix(PromiseObservable): fromPromise does not accept PromiseLike object

[midnight-wonderer]

I can not use Observable.fromPromise with promises from when.
The class is clearly documented that it should accept Promises/A+ spec compliant Promise.
I think the type should be relaxed.

[coveralls]

Coverage remained the same at 97.68% when pulling 8b20019 on MidnightWonderer:bug/too-strict-type-checking into 3e9d529 on ReactiveX:master.

[kwonoj]

And interestingly we didn't have test cases for this cases as well. @MidnightWonderer , would you mind to update PR to include one test cases for given changes?

[coveralls]

Coverage decreased (-0.07%) to 97.612% when pulling a0b2f1a on MidnightWonderer:bug/too-strict-type-checking into 3e9d529 on ReactiveX:master.

[midnight-wonderer]

Hi @kwonoj, I am not really sure how to test the changes because they are all about the type declaration itself and not the implementation details.

How about a new class exposes only what defined in PromiseLike interface as in my new updates?
If the test fails it will fail at the transpilation step, not the execution step.

I can't see why the test affects code coverage in any way. (unless you count the coverage inside the spec itself)

[coveralls]

Coverage remained the same at 97.612% when pulling 7d04f24 on MidnightWonderer:bug/too-strict-type-checking into e14fa8e on ReactiveX:master.

[coveralls]

Coverage decreased (-0.07%) to 97.612% when pulling a0b2f1a on MidnightWonderer:bug/too-strict-type-checking into 3e9d529 on ReactiveX:master.

[kwonoj]

I was originally thinking replicate existing test cases but using non-native promise (like bluebird), but this test looks ok to me. I'll leave this PR opened to get another approval, or feedback.

[kwonoj]

I guess this is for minor, labeled it for now.

[staltz]

PR LGTM

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.